Consolidate .yml files into webpacker.yml #403
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| # Note: You must restart bin/webpack-dev-server for changes to take effect | ||
|
|
||
| default: &default | ||
| devServer: # https://webpack.js.org/configuration/dev-server/ | ||
|
There was a problem hiding this comment. camelCase is uncommon in other |
||
| enabled: true # Enabled by default in development | ||
|
There was a problem hiding this comment. Are we using this option anywhere? What's it supposed to do? There was a problem hiding this comment. Oh yes, we are not using this anymore after #397. Will remove 👍 |
||
| host: localhost # Dev server host | ||
| port: 8080 | ||
| https: false | ||
|
|
||
| paths: # ~ = Rails.root | ||
| source: app/javascript # ~/:source | ||
| entry: packs # ~/:source/:entry | ||
| output: packs # ~/public/:output | ||
| manifest: manifest.json # ~/public/:output/:manifest | ||
| config: config/webpack # ~/:config | ||
|
There was a problem hiding this comment. I'd like to propose a flattened set of options that drops source_path: app/javascript
source_entry_path: packs
public_output_path: packsIn doing so, we'd drop the There was a problem hiding this comment. I think it makes sense and since the output directory can be modified the manifest can remain same 👍 Yep, was thinking same for There was a problem hiding this comment. In regards to removing paths, I feel it's much nicer to keep it under some namespace like we have for dev-server - keeps it consistent and clean. WDYT? There was a problem hiding this comment. Actually, we should probably flatten all of the namespaces. They don't merge into the environments like you'd expect: >> config = YAML.load_file("webpacker.yml")
>> config["default"]["paths"]
=> {"source"=>"app/javascript", "entry"=>"packs", "output"=>"packs", "manifest"=>"manifest.json", "config"=>"config/webpack"}
>> config["test"]["paths"]
=> {"output"=>"packs-test"}There was a problem hiding this comment. So the dev server options should be flattened to There was a problem hiding this comment. Yepp, that would work 👍 Although a bit repetitive and verbose if we start to have many options, especially for the dev server - default: &default
dev_server_host: localhost
dev_server_port: 8080
dev_server_https: false
dev_server_hot: false
source_path: app/javascript
source_entry_path: packs
public_output_path: packs VS default: &default
dev_server: # https://webpack.js.org/configuration/dev-server/
host: localhost # Dev server host
port: 8080
https: false
hot: false
paths: # ~ = Rails.root
source: app/javascript # ~/:source
entry: packs # ~/:source/:entry
output: packs # ~/public/:outputThere was a problem hiding this comment. The more important part is that those namespaces won't work if you want to change part of them in an environment. For example: >> config = YAML.load("
default: &default
paths:
source: app/javascript
entry: packs
output: packs
production:
<<: *default
paths:
output: foo
")
=> {"default"=>{"paths"=>{"source"=>"app/javascript", "entry"=>"packs", "output"=>"packs"}}, "production"=>{"paths"=>{"output"=>"foo"}}}
>> config["production"]["paths"]["source"]
=> nil
>> config["production"]["paths"]["entry"]
=> nil
>> config["production"]["paths"]["output"]
=> "foo"There was a problem hiding this comment. How about this ? # Note: You must restart bin/webpack-dev-server for changes to take effect
dev_server_defaults: &dev_server_defaults # https://webpack.js.org/configuration/dev-server/
host: localhost # Dev server host
port: 8080
https: false
paths_defaults: &paths_defaults # ~ = Rails.root
source: app/javascript # ~/:source
entry: packs # ~/:source/:entry
output: packs # ~/public/:output
default: &default
dev_server:
<<: *dev_server_defaults
paths:
<<: *paths_defaults
extensions:
- .coffee
- .js
- .jsx
- .ts
- .vue
- .sass
- .scss
- .css
- .png
- .svg
- .gif
- .jpeg
- .jpg
development:
<<: *default
test:
<<: *default
paths:
<<: *paths_defaults
output: packs-test
production:
<<: *default
dev_server:
<<: *dev_server_defaults
host: 0.0.0.0 # Cloud9
port: 8080
https: true
There was a problem hiding this comment. Looking again - feels like it will be much better if we just flatten it 👍 |
||
|
|
||
| extensions: | ||
| - .coffee | ||
| - .js | ||
| - .jsx | ||
| - .ts | ||
| - .vue | ||
| - .sass | ||
| - .scss | ||
| - .css | ||
| - .png | ||
| - .svg | ||
| - .gif | ||
| - .jpeg | ||
| - .jpg | ||
|
There was a problem hiding this comment. WDYT about moving There was a problem hiding this comment. Makes sense I think 👍 |
||
|
|
||
| development: | ||
| <<: *default | ||
|
|
||
| test: | ||
| <<: *default | ||
|
|
||
| devServer: | ||
| enabled: false | ||
|
|
||
| paths: | ||
| manifest: manifest-test.json | ||
|
There was a problem hiding this comment. Maybe it'd be better to use There was a problem hiding this comment. Don't think we need a different |
||
|
|
||
| production: | ||
| <<: *default | ||
|
|
||
| devServer: | ||
| host: example.com | ||
| port: | ||
| enabled: false | ||
| https: true | ||
|
There was a problem hiding this comment. Any reason for adding this? Seems like it's encouraging use in production. There was a problem hiding this comment. Some folks are using custom domain + https. Perhaps, I will change this to a dev domain. Related to #319 There was a problem hiding this comment. #319 is about using There was a problem hiding this comment. Ahh yes my bad, mixed it up with this one - #176. Changed it to There was a problem hiding this comment. I still don't think we should provide any different |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of dropping
ARGVentirely, maybe we should parse it and use the relevant options when supplied. Something along the lines of#{options["host"] || dev_server["host"]}. WDYT?