only use dev server in manifest if it's enabled #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manifest-test.json will include references to the dev server, even though it's not enabled by default. This means that system-style tests will not bring in the managed assets.
gauravtiwari
approved these changes
Apr 30, 2017
rubys
added a commit
to rubys/awdwr
that referenced
this pull request
May 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The dev server is configured to be disabled by default in the test environment. However, this setting is ignored when writing the manifest. I believe this was erroneously changed in #295
Solution
Restore that line of code so that if the dev server is not enabled, don't use it in the manifest.