Record the compilation digest even on webpack error #2117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2113
Previously, in #1764, the recording of the compilation digest was ensured to happen only after webpacker ran, but during that fix, it was also made that the digest was only recorded if Webpack succeeded. However, whether Webpack succeeds is not a measure of whether or not webpack emits output, meaning that the digest wouldn't be recorded in the case of a Typescript compilation error, even though new output file(s) were emitted. This divergence could cause either too many or too few compilations, as noted in #2113. This fix still moves the writing of the digest after Webpack runs, but does so regardless of whether Webpack succeeds.