-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport SHA digest file checking to 3-x-stable #1749
Conversation
@mdesantis @gauravtiwari I backported #1743 here. |
thanks @ericboehs ❤️ |
Thank you @ericboehs!!! |
Thanks @ericboehs! Do you guys know when you might release a new version with the changes in this PR? Over here we run multiple app servers under a load balancer (with a Capistrano-style deployment strategy) so I've been pulling my hair out trying to solve the problem we were having with the fact that our I'd rather lock to a gem version than a git branch, but I guess that's the option I'll have to go with in the meantime. Is there somewhere I can find a release schedule @gauravtiwari? 😃 |
Interesting. Thinking about this, it would seem this would be a much wider spread problem. With sprockets the previous 2 versions of an asset were kept around for active users of the site during a deploy. With Webpacker, currently no packs are caching across deploys if the mtime isn't working correctly (all Heroku builds and it sounds like possibly capistrano as well). Once you update your app to use this fix, you'll have another problem. All versions of an asset are kept forever. This is the existing behavior for users where mtime is working correctly (or
It would make sense to wait to deploy both of these fixes together but I'm not a core maintainer here so I'm not sure what the plan is. |
@kjleitz why don't you use |
@mdesantis I'm having trouble finding documentation for the |
@kjleitz See the last paragraph: https://github.com/rails/webpacker/blob/v3.5.5/docs/troubleshooting.md#compilation-triggered-even-when-files-havent-changed
I removed this documentation in this commit by the way. If you look at the code I removed, you can see what setting the CI variable would do in older versions of webpacker (e.g. 3.5.5). Edit: Technically @mdesantis removed it, I just back ported it. ;) |
Thanks Both :) Hey @kjleitz Will make another release over the weekend but in meantime please use the CI var as suggested by @mdesantis |
Ah, thanks @ericboehs @gauravtiwari @mdesantis! A little bit concerned that the environment variable is named Side note (and I'm sorry, I know this isn't exactly the venue for this, but): it's pretty rough navigating the docs for Webpacker—any reason they aren't all just in Thank you guys for the help! I think it'll relieve a big headache/mystery we've been dealing with. |
See #1743