Use correct protocol #1425
Merged
Use correct protocol #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we can run webpacker in either http or https mode.
But if we run webpacker in http mode but access it through a reverse proxy handling https, then it will break because the reverse proxy will have set HTTP_X_FORWARDED_PROTO to https and webpack-dev-server will try to understand the request as a secured one.
We must override X_FORWARDED_PROTO in the same way as we override the other headers.
In the meantime I'm using this initializer as a workaround doing exactly the same work as this PR :
```ruby
# config/initializers/webpacker.rb
require "webpacker/dev_server_proxy.rb"
module Webpacker::DevServerProxy::ProtoOverride
def perform_request(env)
env["HTTP_X_FORWARDED_PROTO"] = Webpacker.dev_server.protocol
super(env)
end
end
Webpacker::DevServerProxy.include Webpacker::DevServerProxy::ProtoOverride
```
|
might be duplicate of #1420 (sorry I just wanted to share our workaround) |
|
Glad to see I'm not crazy! Funny that we both ran into the same issue around the same time |
|
thanks @Systho |
gauravtiwari
pushed a commit
that referenced
this pull request
Apr 29, 2018
Currently we can run webpacker in either http or https mode. But if we run webpacker in http mode but access it through a reverse proxy handling https, then it will break because the reverse proxy will have set HTTP_X_FORWARDED_PROTO to https and webpack-dev-server will try to understand the request as a secured one. We must override X_FORWARDED_PROTO in the same way as we override the other headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we can run webpacker in either http or https mode.
But if we run webpacker in
httpmode but access it through a reverse proxy handlinghttps, then it will break because the reverse proxy will have setHTTP_X_FORWARDED_PROTOtohttpsand webpack-dev-server will try to understand the request as a secured one.We must override
X_FORWARDED_PROTOin the same way as we override the other headers.In the meantime I'm using this initializer as a workaround doing exactly the same work as this PR :