Return false in production environments #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javan
suggested changes
Jan 14, 2018
lib/webpacker/dev_server.rb
Outdated
| else | ||
| Socket.tcp(host, port, connect_timeout: connect_timeout).close | ||
| true | ||
| end |
There was a problem hiding this comment.
I think this should be inverted and check env.development? instead. We have production-like envs (staging, beta) that we want skipped too.
if env.development?
Socket.tcp(host, port, connect_timeout: connect_timeout).close
true
else
false
endThere was a problem hiding this comment.
All production like environments will have NODE_ENV=production and that will evaluate env.production? to true so the logic will work for all production like environments as long as NODE_ENV is set. Would that work?
def env
(ENV["NODE_ENV"].presence_in(available_environments) ||
Rails.env.presence_in(available_environments) ||
"production".freeze).inquiry
endReason for scoping to production was that, in case someone wants to use dev server in test environment. What do you think?
There was a problem hiding this comment.
Perhaps we can check if dev_server is configured? Since, by default, it's only in development:
webpacker/lib/install/config/webpacker.yml
Lines 33 to 38 in 6695445
There was a problem hiding this comment.
Ahh yes, good idea 👍
kawikadkekahuna
added a commit
to wealthfit/webpacker
that referenced
this pull request
Jan 29, 2018
* 'master' of https://github.com/rails/webpacker: (21 commits) Update Ruby versions on Travis CI (rails#1230) Make rubocop happy Fix asset helper for non-css assets in hmr mode CSP warning for Rails 5.2 use 2 spaces for indentation in template injection Update README.md (rails#1198) Remove duplicate yarn-error.log (rails#1197) 3.2.1 Revert file loader (rails#1196) Update default extensions and move to installer (rails#1181) Gitignore (rails#1195) Update uglify plugin (rails#1194) Fixes Vue root instance initialization (rails#1187) Return false in production environments (rails#1179) Fix url loader doc[ci skip] (rails#1183) Use inject_into_file to support rails 4.2 Update gems and npm deps (rails#1180) asset_pack_path + HMR fix; Closes rails#1171 (rails#1172) enhance CHANGELOG.md (rails#1170) CI against Ruby 2.5.0 ...
ttanimichi
added a commit
to reactjs/react-rails
that referenced
this pull request
Aug 6, 2018
```
Error:
PagesControllerTest#test_it_mounts_components_from_the_dev_server:
RuntimeError: Failed to start dev server
/home/travis/build/reactjs/react-rails/test/support/webpacker_helpers.rb:65:in `with_dev_server'
/home/travis/build/reactjs/react-rails/test/react/rails/pages_controller_test.rb:32:in `block (2 levels) in <class:PagesControllerTest>'
```
Related to rails/webpacker#1179
hardcarry1995
pushed a commit
to hardcarry1995/react-rails
that referenced
this pull request
Jan 9, 2023
```
Error:
PagesControllerTest#test_it_mounts_components_from_the_dev_server:
RuntimeError: Failed to start dev server
/home/travis/build/reactjs/react-rails/test/support/webpacker_helpers.rb:65:in `with_dev_server'
/home/travis/build/reactjs/react-rails/test/react/rails/pages_controller_test.rb:32:in `block (2 levels) in <class:PagesControllerTest>'
```
Related to rails/webpacker#1179
goldapple911
added a commit
to goldapple911/react-rails
that referenced
this pull request
Aug 15, 2023
```
Error:
PagesControllerTest#test_it_mounts_components_from_the_dev_server:
RuntimeError: Failed to start dev server
/home/travis/build/reactjs/react-rails/test/support/webpacker_helpers.rb:65:in `with_dev_server'
/home/travis/build/reactjs/react-rails/test/react/rails/pages_controller_test.rb:32:in `block (2 levels) in <class:PagesControllerTest>'
```
Related to rails/webpacker#1179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1173
This PR enables bypassing of dev server check in production environment since the assets are precompiled in production environments.