silence yarn output if checking is successfull #1131

doits · 2017-12-19T18:17:17Z

on every rake or rails call I get this output:

yarn check v1.3.2
warning package.json: No license field
warning No license field
success Folder in sync.
✨  Done in 0.18s.

why not silence it if everything is in sync and only display it in case of errors?

gauravtiwari · 2017-12-19T18:49:47Z

lib/webpacker/railtie.rb

@@ -37,6 +37,10 @@ class Webpacker::Engine < ::Rails::Engine
        warn "To disable this check, please add `config.webpacker.check_yarn_integrity = false`"
        warn "to your Rails development config file (config/environments/development.rb)."
        warn "\n\n"
+        warn "Yarn output while checking for integrity:"


Do you think we need this line? Think above is enough

you're right, I just removed it

gauravtiwari reviewed Dec 19, 2017

View reviewed changes

silence yarn output if checking is successfull

a185233

doits force-pushed the silence_yarn_check_on_success branch from dd93406 to a185233 Compare December 19, 2017 22:28

guilleiguaran merged commit 500d18d into rails:master Dec 20, 2017

guilleiguaran mentioned this pull request Jan 12, 2018

Yarn integrity check should be silent when it passes #1169

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

silence yarn output if checking is successfull #1131

silence yarn output if checking is successfull #1131

doits commented Dec 19, 2017

gauravtiwari Dec 19, 2017 •

edited

Loading

doits Dec 19, 2017 •

edited

Loading

silence yarn output if checking is successfull #1131

silence yarn output if checking is successfull #1131

Conversation

doits commented Dec 19, 2017

gauravtiwari Dec 19, 2017 • edited Loading

Choose a reason for hiding this comment

doits Dec 19, 2017 • edited Loading

Choose a reason for hiding this comment

gauravtiwari Dec 19, 2017 •

edited

Loading

doits Dec 19, 2017 •

edited

Loading