Adds tests for environment.toWebpackConfig #1099
Conversation
Adds a root module to the npm pacakge to make it possible to customize the RAILS_ROOT location. Supporting this approach means ensuring that relative paths for various Webpack configuration items resolve relative to the given root if it exists.
rossta
force-pushed
the
add-environment-package-tests
branch
from
d4ea578
to
755174d
Compare
package/root.js
Outdated
| @@ -0,0 +1,11 @@ | |||
| const { resolve, join } = require('path') | |||
| const root = process.env.RAILS_ROOT || ''; | |||
There was a problem hiding this comment.
What do you think about using process.cwd()? - fs.realpathSync(process.cwd())
package/environment.js
Outdated
| @@ -77,7 +78,7 @@ const getBaseConfig = () => | |||
| }, | |||
|
|
|||
| resolveLoader: { | |||
| modules: ['node_modules'] | |||
| modules: [join(root, 'node_modules')] | |||
There was a problem hiding this comment.
Don't think this is necessary??
|
Turns out we can change the working directory of the test process, taking advantage of how we execute requires of the default and project webpacker.yml files, without changing application code. I'm not sure how useful the original approach of introducing a configurable Rails root would be. In any case, it should probably be a separate PR rather than a side effect of trying to test existing app code. |
| @@ -1,4 +1,5 @@ | |||
| /* global test expect */ | |||
| console.log('objectify test cwd', process.cwd()); | |||
There was a problem hiding this comment.
No, that was a debugging line that should be removed (and looks like you've done that on master already).
|
Awesome @rossta 💯 🍰 Just one minor comment and then we can merge. Thank you :) |
As a follow up to #1097 and #1098, I've taken a stab at adding tests for
environment.toWebpackConfig.Because the
environmentmodule assumes the location ofconfig/webpacker.yml, adding tests for this module presents a challenge since this location does not exists relative to the root of the project. Possible approaches include simply addingconfig/webpacker.ymlto the root of the project (and potentially other app files, likeapp/javascript/packs), generating files during the test run, or using a mock filesystem.The approach I landed on makes it possible to customize the
RAILS_ROOTlocation so that the environment paths resolve relative totest/test_appin tests. While approach adds flexibility, it also means ensuring that relative paths, e.g.node_modules, resolve relative to the given root if it exists.Let me know what you think of this approach.