-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3014 - Outdated submissions banner #3231
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3231 +/- ##
===========================================
- Coverage 90.65% 90.59% -0.07%
===========================================
Files 299 299
Lines 8490 8526 +36
Branches 794 802 +8
===========================================
+ Hits 7697 7724 +27
- Misses 676 684 +8
- Partials 117 118 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
tdrs-frontend/src/components/SubmissionHistory/SubmissionHistory.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, doesn't halt anything. LGTM
LGTM @jtimpe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jtimpe this PR delivers the following expected results 🥇 :
- Banner appears when files were submitted prior to May 31, 2024 ✔️
- error report is unavailable for abovementioned files ✔️
However, we believe this change is now out-of-scope given the reparsing work. In particular:
- when files are reparsed, the submission history metadata, including the error reports, could be refreshed, but if the reparsed file was submitted prior to May 31, 2024, this report will still be unavailable (see evidence below)
- The data team considered some possible conditions to apply that could help make this workable, including:
- changing the date to something much earlier (e.g. Dec 31, 2023)
- adding a condition to display the error report if the file has been reparsed
- making the error report unavailable if a file has been resubmitted
All of these alternatives scope-creep the ticket and adds unnecessary complexity to an otherwise great solution to a problem (i.e. STTs reviewing and asking Qs about outdated reports) that we think is now resolved with the reparsing feature.
@ADPennington we could potentially make use of the new |
@ADPennington i made the change to include information about the datafile's reparses inside of the api response. The Submission History page now checks the One caveat is that the Submission History page maintains the original created date. So, if that date is prior to May 31 2024, but the file has a more recent reparse, it may be slightly confusing. Ideally there would be a way to show the file's version history a little more clearly with respect to reparse. Open to suggestions on that front. |
thank you for this update @jtimpe -- I plan to retest with @ttran-hub and @klinkoberstar early next week. in the meantime, if @victoriaatraft and @reitermb would like to explore this solution in a deployed environment, please feel free 😄 |
Summary of Changes
Pull request closes #3014
How to Test
created_at
field of the datafile to before 5/31/2024Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):