-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/make erd docker login #3226
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3226 +/- ##
===========================================
- Coverage 92.66% 90.86% -1.81%
===========================================
Files 47 295 +248
Lines 1009 8437 +7428
Branches 169 789 +620
===========================================
+ Hits 935 7666 +6731
- Misses 42 658 +616
- Partials 32 113 +81
Flags with carried forward coverage won't be shown. Click here to find out more. see 247 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ANF-app into hotfix/make-erd-docker-login
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrew-jameson feel free to revert the branch changes on this PR. lgtm!
Summary of Changes
Adds
docker-login
ahead of docker pull usage per #3165 and this thread from @ADPennington. Also addressed an unseen technical debt issue that pipeline did not fail when artifact was not found.How to Test
Latest pipeline shows passing
make_erd
and artifact now exists.Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):