forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1755 - As a data analyst, I need to be able to upload SSP data files #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…app into feat/1755-ssp-data-types
…154_assign_filename_ssp_section_after_uploading_file
28 tasks
ADPennington
reviewed
Nov 7, 2022
7 tasks
…mes property. May update again soon
6 tasks
Admin/2239 update qtrmon string
…into 2154+1755-jtjt
raftmsohani
added
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
and removed
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Nov 8, 2022
28 tasks
andrew-jameson
approved these changes
Nov 8, 2022
ADPennington
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work dev team! @n0remac @raftmsohani @jtimpe 🥇 cc: @andrew-jameson ready to merge! cc: @ttran-hub
testing notes below:
SSP state (46:50): Vermont, submitting as Data Analyst
for Q2, 2022: section 1 and 4 (state doesnt submit section 4)
-
results: 🚀
-
data submission
- modal works when changing selections for file type before submission ✔️
- anchor to submission result looks good. ✔️
- all users associated with STT get data submission emails ✔️
- data submission for OFA Admins look good, too (submitted tanf + ssp for CA). ✔️
-
non-SSP state: Mississippi (25:28), submitting for Q2, 2022: section 1 and 4 (doesnt submit SSP, submits section 4)
-
results: 🚀
- no SSP on frontend ✔️
- no SSP on backend in STTs model ✔️
tribe: Nez Perce Tribe (86:168), submitting for Q2, 2022: section 1 and 4 ( doesnt submit section 4 or SSP)
-
results: 🚀
- no SSP on frontend ✔️
- no SSP on backend in STTs model ✔️
- email looks good. like the addition of
Tribal
in subject ✔️
territory: VI (54:78), submitting for Q2, 2022: section 1 and 4 ( doesnt submit section 4 or SSP)
-
results: 🚀
- no SSP on frontend ✔️
- no SSP on backend in STTs model ✔️
all files submitted to titan (none
are for files like s4 that some stts dont submit)
ADPennington
added
Ready to Merge
and removed
QASP Review
Deploy with CircleCI-qasp
Deploy to https://tdp-frontend-qasp.app.cloud.gov through CircleCI
labels
Nov 8, 2022
This was referenced Nov 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Provide a brief summary of changes
Pull request closes #1755 #2154
This recording shows a dev belonging to an STT that has SSP access submitting those file:
https://user-images.githubusercontent.com/7119690/200042287-a4cee7ea-080f-4e03-bfad-6bf890d018b1.mov
This recording shows a dev belonging to an STT withou SSP access submitting a TANF file:
https://user-images.githubusercontent.com/7119690/200042478-799a6e90-61a5-415d-9aa1-5771f61b7b8c.mov
This recording shows a OFA Admin selecting an STT with SSP access and submitting TANF and SSP files. There is a bug where the previously uploaded file displayed is first file uploaded for that section instead of the last:
https://user-images.githubusercontent.com/7119690/200042661-c9649db7-df46-4588-9134-b08b790ced56.mov
How to Test
ssp = True
) assigned.ssp = False
for the user's STT)GET
request)Ssp
will be prepended to the data report'ssection
in the Django Admin Console (when TANF is selected, nothing is prepended)GET
request)ssp = True
, the file name should be selected from theSSP ${section}
of the STT'sfilenames
.filenames
, this will throw an exception. I believe this is an existing issue and will be addressed with future work.Deliverables
1755 ACS:
2154 ACS:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):