Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/2090 transferred files must renamed acf titan #2122

Merged

Conversation

raftmsohani
Copy link

@raftmsohani raftmsohani commented Sep 8, 2022

Summary of Changes

Provide a brief summary of changes
Pull request closes #2090 _

How to Test

List the steps to test the PR
These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 
  1. Open http://localhost:3000/ and sign in.
  2. Proceed with functional tests as described herein.
  3. Test steps should be captured in the demo GIF(s) and/or screenshots below.

Demo GIF(s) and screenshots for testing procedure

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

  • The uploaded filenames should be correct based on section for Tribes and States
  • lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

  • Are all areas of code introduced in this PR meaningfully tested?
    • If this PR introduces backend code changes, are they meaningfully tested?
    • If this PR introduces frontend code changes, are they meaningfully tested?
  • Are code coverage minimums met?
    • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
    • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

  • Are backend code style checks passing on CircleCI?
  • Are frontend code style checks passing on CircleCI?
  • Are code maintainability principles being followed?

Deliverable 4: Accessible

  • Does this PR complete the epic?
  • Are links included to any other gov-approved PRs associated with epic?
  • Does PR include documentation for Raft's a11y review?
  • Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

  • Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

  • Does this PR provide background for why coding decisions were made?
  • If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
  • If this PR introduces dependencies, are their licenses documented?
  • Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

  • Does the OWASP Scan pass on CircleCI?
  • Do manual code review and manual testing detect any new security issues?
  • If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

  • the purpose of the research
  • methods used to conduct the research
  • who participated in the research
  • what was tested and how
  • impact of research on TDP
  • (if applicable) final design mockups produced for TDP development

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #2122 (3bb6517) into release/v2.1.0 (c9c11ac) will decrease coverage by 0.09%.
The diff coverage is 62.50%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v2.1.0    #2122      +/-   ##
==================================================
- Coverage           95.00%   94.91%   -0.10%     
==================================================
  Files                  79       78       -1     
  Lines                2103     2105       +2     
  Branches              287      290       +3     
==================================================
  Hits                 1998     1998              
- Misses                 75       77       +2     
  Partials               30       30              
Flag Coverage Δ
dev-backend 95.21% <57.14%> (-0.59%) ⬇️
dev-frontend 94.29% <100.00%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tdrs-backend/tdpservice/settings/common.py 100.00% <ø> (ø)
...rs-frontend/src/components/GovBanner/GovBanner.jsx 80.00% <ø> (+32.94%) ⬆️
tdrs-frontend/src/components/Profile/Profile.jsx 81.25% <ø> (-2.09%) ⬇️
...-frontend/src/components/SplashPage/SplashPage.jsx 100.00% <ø> (ø)
tdrs-backend/tdpservice/middleware.py 57.14% <30.76%> (-42.86%) ⬇️
tdrs-backend/tdpservice/data_files/models.py 86.55% <100.00%> (+0.34%) ⬆️
...ackend/tdpservice/users/api/authorization_check.py 100.00% <100.00%> (ø)
tdrs-frontend/src/actions/auth.js 100.00% <100.00%> (ø)
tdrs-frontend/src/components/Button/Button.jsx 100.00% <100.00%> (ø)
tdrs-frontend/src/components/Reports/Reports.jsx 87.32% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c11ac...3bb6517. Read the comment docs.

@raftmsohani raftmsohani changed the base branch from release/v2.1.0 to develop September 14, 2022 13:45
@raftmsohani raftmsohani merged commit c534e51 into develop Oct 18, 2022
@raftmsohani raftmsohani deleted the feat/2090-Transferred-files-must-renamed-ACF-Titan branch October 18, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transferred files must be renamed on ACF Titan
2 participants