Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds finalized Knowledge Center Content #1940

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Adds finalized Knowledge Center Content #1940

merged 5 commits into from
Jul 15, 2022

Conversation

reitermb
Copy link

@reitermb reitermb commented Jul 11, 2022

This PR closes #1693

Summary of Changes

  • Adds subdirectory to project updates environment to host Knowledge Center
  • Adds Knowledge center content
  • Bumps USWDS CSS version to support needed content
  • Bumps jquery version
  • Adds Lity to applicable pages to support accessible lightboxes
  • Adds MVP version of "Back to top" functionality via anchor tags on applicable (read: long) pages

How to Test

This PR is identical to what's currently hosted in my Project Updates environment Staging Repo. It can be accessed at: https://reitermb.github.io/Test/knowledge-center/ and browsed as a repo: https://github.com/reitermb/Test

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1940 (79a4b86) into develop (7ba13f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1940   +/-   ##
========================================
  Coverage    95.17%   95.17%           
========================================
  Files           78       78           
  Lines         2072     2072           
  Branches       281      281           
========================================
  Hits          1972     1972           
  Misses          69       69           
  Partials        31       31           
Flag Coverage Δ
dev-backend 95.80% <ø> (ø)
dev-frontend 93.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba13f4...79a4b86. Read the comment docs.

@reitermb reitermb requested a review from lfrohlich July 11, 2022 16:58
@reitermb
Copy link
Author

reitermb commented Jul 11, 2022

cc @ttran-hub @ADPennington
Re: Prior a11y review

  • Sidenav List element has direct children that are not allowed inside <li> elements looks like it was a false positive
  • All broken links should be working now
  • All headings should be in the correct hierarchical order now
  • Lengthy pages have a basic back to top link at the end now (there are ways to make it fancier, e.g. smooth scrolling and/or floating buttons in the future, but both would have added quite a bit of scope to do accessibly right now)
  • Page titles should now be descriptive and unique
  • Added what should be a fully accessible lightbox to all images (focus should be correctly trapped when the lightbox is open, alt text should be accessible by screenreaders in lightbox mode, keyboard nav should be supported for entering and exiting lightbox)

@reitermb reitermb added the a11y-review PR is ready for accessibility review label Jul 11, 2022
@ADPennington ADPennington added Gov A11y Review and removed a11y-review PR is ready for accessibility review labels Jul 11, 2022
@ADPennington
Copy link
Collaborator

@ttran-hub this is ready for gov a11y review. @reitermb please connect with Thomas for a walk-through of the changes you mentioned 🆙

@ttran-hub
Copy link
Collaborator

ttran-hub commented Jul 12, 2022

Thanks @reitermb, the nav nesting fixes the list element under the first bullet one and others are good. a11y LGTM! 🚀

Copy link
Collaborator

@ADPennington ADPennington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾 thanks @reitermb @lilybl1. cc: @ttran-hub @lfrohlich

@reitermb reitermb merged commit d1fb301 into develop Jul 15, 2022
@reitermb reitermb deleted the knowledge-center branch July 15, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a grantee pilot user I want to be able to access the knowledge center through project updates environment
4 participants