forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat 1133 files transfer to ACF Titan #1918
Merged
andrew-jameson
merged 121 commits into
release/v2.1.0
from
feat/1133-files-transferred-to-ACF-Titan
Sep 16, 2022
Merged
feat 1133 files transfer to ACF Titan #1918
andrew-jameson
merged 121 commits into
release/v2.1.0
from
feat/1133-files-transferred-to-ACF-Titan
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raftmsohani
changed the title
added ToDo comments where the logic has to be added
[WIP] feat 1133 files transfer to ACF Titan
Jun 28, 2022
To run Celery, run: |
andrew-jameson
added
Deploy with CircleCI-sandbox
and removed
Deploy with CircleCI-sandbox
labels
Jul 7, 2022
n0remac
reviewed
Jul 28, 2022
raftmsohani
changed the title
[WIP] feat 1133 files transfer to ACF Titan
feat 1133 files transfer to ACF Titan
Jul 29, 2022
raftmsohani
added
Deploy with CircleCI-sandbox
QASP Review
and removed
Deploy with CircleCI-sandbox
QASP Review
labels
Sep 13, 2022
n0remac
force-pushed
the
feat/1133-files-transferred-to-ACF-Titan
branch
from
September 13, 2022 19:15
1b613fc
to
51e676f
Compare
I accidentally added commits from my branch so I removed them and force pushed. |
n0remac
added
Deploy with CircleCI-sandbox
and removed
Deploy with CircleCI-sandbox
labels
Sep 13, 2022
n0remac
added
Deploy with CircleCI-sandbox
and removed
Deploy with CircleCI-sandbox
labels
Sep 13, 2022
n0remac
force-pushed
the
feat/1133-files-transferred-to-ACF-Titan
branch
from
September 13, 2022 19:40
6ad2a58
to
51e676f
Compare
raftmsohani
added
Deploy with CircleCI-sandbox
and removed
Deploy with CircleCI-sandbox
labels
Sep 13, 2022
ADPennington
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @raftmsohani. successfully tested this using dev and prod credentials to titan 🚀
Please note:
- the pilot files for states and tribes are properly renamed when landing on titan.
- any section 4 files submitted by STTs that do not have a "Stratum Data" section included in the STT model's filenames field have an invalid name upon landing on titan, as expected.
- any sections in the STT model's filenames field that are preceded by "SSP" will have invalid file names upon landing on titan, as expected at this stage. As an STT data analyst, I need to tell TDP which data report I am uploading #1755 will resolve this.
- territories' files have proper file names upon landing on titan, except in cases where section 4 data is erroneously submitted. this is expected.
- i have added the prod key value pairs to prod backend app in cloud.gov in preparation for merge to master.
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Provide a brief summary of changes
Pull request closes #1133
How to Test
List the steps to test the PR
To test the upload task:
As can be seen below, when the file is uploaded, the renamed file is going to be logged in the Legacy File transfer section with all the information and a link to the uploaded file.
Add the following lines to .env file:
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):