-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/1746-new-routes-and-services-tanf-staging-space #1864
feat/1746-new-routes-and-services-tanf-staging-space #1864
Conversation
…es-and-services-tanf-staging-space
Codecov Report
@@ Coverage Diff @@
## develop #1864 +/- ##
========================================
Coverage 94.97% 94.97%
========================================
Files 78 78
Lines 2088 2088
Branches 284 284
========================================
Hits 1983 1983
Misses 75 75
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…tes-and-services-tanf-staging-space
…746-new-routes-and-services-tanf-staging-space
…es-and-services-tanf-staging-space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riatzukiza Code looks fine to me, I'm testing now. However, to close those tickets, you'll need to update the documentation which each ticket has in the tasks section. Let me know if you have any questions or concerns on that.
docs/Technical-Documentation/Architecture-Decision-Record/008-deployment-flow.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor doc updates requested but otherwise good to go.
…deployment-flow.md Co-authored-by: Andrew <84722778+andrew-jameson@users.noreply.github.com>
Co-authored-by: Andrew <84722778+andrew-jameson@users.noreply.github.com>
testing staging deployment for hhs:main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great 🚀 thanks @riatzukiza 👍🏾 Some notes and one minor change requested below:
- successfully tested As tech lead, I need new routes and services for deployments from tanf-app/develop branch to tanf-staging space #1746.
- I tested for Configure HHS/TANF-app:Main CircleCI jobs to deploy to the staging space #1745 on this branch:
- deployment intended for hhs:main was successful (see ci workflow here). As expected, I had to change the env vars for clam url, ams, jwt key, and superuser since these default to dev env vars. restaging backend after the change was fine and i was able to perform all the expected functions on the staging site.
- i updated ADR 008 on my test branch. Please bring these into this PR prior to merge.
- I will complete this task prior to merging this work into
hhs:main
.
cc: @andrew-jameson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏾 👍🏾
Summary of Changes
Pull request closes #1746 and #1745. Remember to update the filter branches before final approval. Deploys to staging on merge to test-main and deploys to develop on test-develop.
How to Test
These steps are generic, please adjust as necessary.
6 look at stratos panel logs, and test everything again
Tabletop
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):