feat/1746-new-routes-and-services-tanf-staging-space

[riatzukiza]

Summary of Changes

Pull request closes #1746 and #1745. Remember to update the filter branches before final approval. Deploys to staging on merge to test-main and deploys to develop on test-develop.

How to Test

These steps are generic, please adjust as necessary.

cd tdrs-frontend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d
cd tdrs-backend && docker-compose -f docker-compose.yml -f docker-compose.local.yml up -d 

1. Open stratos panel and locate logs for tdp-backend-develop in tanf-staging space
2. Go to https://tdp-frontend-develop.app.cloud.gov try to upload a file, go to the admin panel, etc
3. confirm that the backend is getting hit by requests from the frontend in the logs
4. with the filters changed from what is to be merged, create a branch from this one, and merge into the branch the temporary filter is set for.
5. open circle CI and find the deployment logs
6. wait for logs to succeed
   6 look at stratos panel logs, and test everything again

Tabletop

• Ready for Tabletop (Reviewer check this)
• Tabletop scheduled (Assignee check this)
• Tabletop approval

Deliverables

More details on how deliverables herein are assessed included here.

Deliverable 1: Accepted Features

Checklist of ACs:

• Cloud.gov AWS S3 created for staticfiles: tdp-staticfiles-develop
• Cloud.gov AWS S3 created for datafiles: tdp-datafiles-develop
• Cloud.gov AWS RDS created for models: tdp-db-develop
• Deployments from develop branch are routed to: https://tdp-frontend-develop.app.cloud.gov/ and https://tdp-backend-develop.app.cloud.gov/
• Testing Checklist has been run and all tests pass
• READMEs and diagrams are updated, if necessary
• Deploy latest code to tanf-staging space on merges to hhs:main with CircleCI
• lfrohlich and/or adpennington confirmed that ACs are met.

Deliverable 2: Tested Code

• Are all areas of code introduced in this PR meaningfully tested?
  • If this PR introduces backend code changes, are they meaningfully tested?
  • If this PR introduces frontend code changes, are they meaningfully tested?
• Are code coverage minimums met?
  • Frontend coverage: [insert coverage %] (see CodeCov Report comment in PR)
  • Backend coverage: [insert coverage %] (see CodeCov Report comment in PR)

Deliverable 3: Properly Styled Code

• Are backend code style checks passing on CircleCI?
• Are frontend code style checks passing on CircleCI?
• Are code maintainability principles being followed?

Deliverable 4: Accessible

• Does this PR complete the epic?
• Are links included to any other gov-approved PRs associated with epic?
• Does PR include documentation for Raft's a11y review?
• Did automated and manual testing with iamjolly and ttran-hub using Accessibility Insights reveal any errors introduced in this PR?

Deliverable 5: Deployed

• Was the code successfully deployed via automated CircleCI process to development on Cloud.gov?

Deliverable 6: Documented

• Does this PR provide background for why coding decisions were made?
• If this PR introduces backend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces frontend code, is that code easy to understand and sufficiently documented, both inline and overall?
• If this PR introduces dependencies, are their licenses documented?
• Can reviewer explain and take ownership of these elements presented in this code review?

Deliverable 7: Secure

• Does the OWASP Scan pass on CircleCI?
• Do manual code review and manual testing detect any new security issues?
• If new issues detected, is investigation and/or remediation plan documented?

Deliverable 8: User Research

Research product(s) clearly articulate(s):

• the purpose of the research
• methods used to conduct the research
• who participated in the research
• what was tested and how
• impact of research on TDP
• (if applicable) final design mockups produced for TDP development

[codecov]

Codecov Report

Merging #1864 (e73ad73) into develop (df4d981) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1864   +/-   ##
========================================
  Coverage    94.97%   94.97%           
========================================
  Files           78       78           
  Lines         2088     2088           
  Branches       284      284           
========================================
  Hits          1983     1983           
  Misses          75       75           
  Partials        30       30           

Flag	Coverage Δ
dev-backend	95.80% <ø> (ø)
dev-frontend	93.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4d981...e73ad73. Read the comment docs.

[andrew-jameson]

@riatzukiza Code looks fine to me, I'm testing now. However, to close those tickets, you'll need to update the documentation which each ticket has in the tasks section. Let me know if you have any questions or concerns on that.

[andrew-jameson]

Some minor doc updates requested but otherwise good to go.

[ADPennington]

looks great 🚀 thanks @riatzukiza 👍🏾 Some notes and one minor change requested below:

• successfully tested As tech lead, I need new routes and services for deployments from tanf-app/develop branch to tanf-staging space #1746.
• I tested for Configure HHS/TANF-app:Main CircleCI jobs to deploy to the staging space #1745 on this branch:
  • deployment intended for hhs:main was successful (see ci workflow here). As expected, I had to change the env vars for clam url, ams, jwt key, and superuser since these default to dev env vars. restaging backend after the change was fine and i was able to perform all the expected functions on the staging site.
  • i updated ADR 008 on my test branch. Please bring these into this PR prior to merge.
  • I will complete this task prior to merging this work into hhs:main.

cc: @andrew-jameson

[ADPennington]

👍🏾 👍🏾