Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.x branch appears to be missing patches #1159

Closed
lukebakken opened this issue Feb 23, 2022 · 5 comments
Closed

7.x branch appears to be missing patches #1159

lukebakken opened this issue Feb 23, 2022 · 5 comments
Assignees
Milestone

Comments

@lukebakken
Copy link
Contributor

While working on #1158 I noticed that the changes in @bollhals PR #1077 don't appear in the 7.x branch.

Here's another questionable place:
#1144 (review)

@michaelklishin @stebet I'm wondering what your thoughts are? I know we have planned 7.x as an "interim" before the "big release" but it seems like the branch can't be trusted right now.

@bollhals
Copy link
Contributor

I've brought this up in various other PRs. I think main should be 7.0 as there aren't big changes in there, with the exception of the basicProperties change to valuetypes.

At this point I have 0 clue whats in the 7.0 branch of all the changes made between 6.2.x and latest main.

@michaelklishin
Copy link
Member

We should forward port what's missing, or we can release off of main.

@lukebakken
Copy link
Contributor Author

Great, thanks for the feedback. I'll wait to see what @stebet says as well but it sounds like main should become 7.0.0 and the current 7.x branch abandoned.

@bollhals
Copy link
Contributor

with the exception of the basicProperties change to valuetypes.

That would be this PR => #1096 (comment)
which I already asked in the PR whether we want to go down this path or not.

@lukebakken
Copy link
Contributor Author

I am going to proceed with renaming the current 7.x branch to 7.x-abandoned. main will become version 7.0.0. I will also update GH milestones to reflect this.

Just maintaining main and 6.x has been more than enough work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants