Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Testing generated parachains in base-parachain. #97

Open
weezy20 opened this issue Apr 3, 2024 · 0 comments
Open

CI: Testing generated parachains in base-parachain. #97

weezy20 opened this issue Apr 3, 2024 · 0 comments
Labels

Comments

@weezy20
Copy link
Contributor

weezy20 commented Apr 3, 2024

E2E tests involving cargo check | building a parachain (and to a lesser extent, an ink contract), can take a while on the CI runner. This slows us down for most tasks (pull requests) that do not pertain to modifying any of the current local *.templ template files which are used to customize the generated parachain.

One approach is to simply #[ignore] these tests, and have them run only on merge to main which is fine (#90). But here we discuss an alternative strategy:

pop new parachain is a result of sourcing base-parachain and applying the customization in the form of templ files that reside locally in this repo. The validation an e2e test like build_parachain makes is to effectively run pop new parachain and then run cargo build --release on it to make sure the generation was successful.

This checks two things:

  1. The *.templ files are valid and up-to-date with the source template, in this case, base-parachain
  2. The base-parachain builds without errors

This can be delegated to base-parachain itself, where one CI check on the base-parachain repository could download the latest pop release binary, run pop new parachain, which in turn uses the release templ files, and effectively check both the validity of the template files in pop-cli and the base-parachain itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants