You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
E2E tests involving cargo check | building a parachain (and to a lesser extent, an ink contract), can take a while on the CI runner. This slows us down for most tasks (pull requests) that do not pertain to modifying any of the current local *.templ template files which are used to customize the generated parachain.
One approach is to simply #[ignore] these tests, and have them run only on merge to main which is fine (#90). But here we discuss an alternative strategy:
pop new parachain is a result of sourcing base-parachain and applying the customization in the form of templ files that reside locally in this repo. The validation an e2e test like build_parachain makes is to effectively run pop new parachain and then run cargo build --release on it to make sure the generation was successful.
This checks two things:
The *.templ files are valid and up-to-date with the source template, in this case, base-parachain
The base-parachain builds without errors
This can be delegated to base-parachain itself, where one CI check on the base-parachain repository could download the latest pop release binary, run pop new parachain, which in turn uses the release templ files, and effectively check both the validity of the template files in pop-cli and the base-parachain itself.
The text was updated successfully, but these errors were encountered:
E2E tests involving
cargo check | build
ing a parachain (and to a lesser extent, an ink contract), can take a while on the CI runner. This slows us down for most tasks (pull requests) that do not pertain to modifying any of the current local*.templ
template files which are used to customize the generated parachain.One approach is to simply
#[ignore]
these tests, and have them run only on merge tomain
which is fine (#90). But here we discuss an alternative strategy:pop new parachain
is a result of sourcingbase-parachain
and applying the customization in the form oftempl
files that reside locally in this repo. The validation an e2e test likebuild_parachain
makes is to effectively runpop new parachain
and then runcargo build --release
on it to make sure the generation was successful.This checks two things:
*.templ
files are valid and up-to-date with the source template, in this case,base-parachain
base-parachain
builds without errorsThis can be delegated to
base-parachain
itself, where one CI check on thebase-parachain
repository could download the latestpop
release binary, runpop new parachain
, which in turn uses the releasetempl
files, and effectively check both the validity of the template files inpop-cli
and thebase-parachain
itself.The text was updated successfully, but these errors were encountered: