-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-API calls #1933
Comments
I think |
Commenting to follow here. @ben-schwen already linked our corresponding issue. |
Looked at this a little bit. I think we can replace I gave up on Alternatively, we might be able to use the C routine https://github.com/r-devel/r-svn/blob/main/src/main/objects.c#L1840 |
@DavisVaughan tested in my package. It passes all unit tests with no NOTE on |
Easy:
SET_ENCLOS()
: Used to create new environments, should be easy to fix: RemoveSET_ENCLOS()
usage rlang#1707PREXPR()/
R_PromiseExpr()`: RemovePREXPR()
usage (as much as we can) rlang#1708Unknown:
SET_S4_OBJECT()
/UNSET_S4_OBJECT()
: Used for proxying / unproxying S4 objects. Can we do better?Problematic:
SETLENGTH()
/SET_TRUELENGTH()
: Used in various algorithms for expansible vectors. Also used in data.table for the same purpose. Would be nice to find a solution with R core.STDVEC_DATAPTR()
: Part of the ALTREP API. Can we get this part of the experimental API that can be used in packages?The text was updated successfully, but these errors were encountered: