Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy_dagitty(..., layout = "dendrogram") is broken #57

Closed
coreyyanofsky opened this issue Aug 6, 2021 · 2 comments · Fixed by #62
Closed

tidy_dagitty(..., layout = "dendrogram") is broken #57

coreyyanofsky opened this issue Aug 6, 2021 · 2 comments · Fixed by #62
Labels
wontfix This will not be worked on

Comments

@coreyyanofsky
Copy link

The function tidy_dagitty contains these two lines:

layout_info <- dplyr::select(ggraph_layout, -x, -y) %>% 
  dplyr::mutate(name = as.character(name))
names(layout_info) <- c("name", ".ggraph.orig_index", "circular", 
  ".ggraph.index")

These lines assume that (excluding x, y) the name column will be first in the ggraph_layout tibble. For layout = dendrogram this assumption is violated: the first column is a logical vector named leaf, which gets renamed to name. (Later on there is a join on name that barfs due to type mismatch.)

@malcolmbarrett malcolmbarrett added the wontfix This will not be worked on label Oct 10, 2021
@malcolmbarrett
Copy link
Collaborator

This is a #wontfix for me. Denodgrams are complex layout types, and it doesn't seem worth the effort to try to support them in ggdag since they're not as useful for this type of structure. I'd recommend working with ggraph directly if you have a pressing use case.

If this is an important feature to you, though, I'm open to a PR to better support them.

@malcolmbarrett
Copy link
Collaborator

Thanks for filing, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants