Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests to throw an error if missingTranslations: true is set unnecessarily #5670

Open
quisquous opened this issue Jul 9, 2023 · 0 comments

Comments

@quisquous
Copy link
Owner

Right now the find missing translations script will note if this is set to true when it's not needed. However, test_trigger.ts and test_timeline.ts are not smart enough to be able to figure this out, because the logic is in different files to figure out if something has been missed.

It'd be nice to somehow be able to enforce that missingTranslations: true is only set if there are missing translations. That way it will be obvious when any file is in a "done" or "not done" state, and so it will be obvious in a PR when this state has changed (and so it doesn't happen accidentally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant