Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: test_timeline - show amount of time between last matched line and the end of the encounter #5617

Open
xiashtra opened this issue Jun 26, 2023 · 1 comment

Comments

@xiashtra
Copy link
Contributor

When testing older timelines to make sure they still work properly, sometimes it's not immediately apparent when the timeline drastically desyncs or the encounter continues past the end of the timeline. It would be nice if the test_timeline utility indicated the delta between the last matched timeline entry and the last line of an encounter, to make it more obvious when this happens. This could possibly also be worked into a heuristic to warn when there is a large window between timeline syncs mid-encounter.

@quisquous
Copy link
Owner

Yeah, I think test_timeline should probably take note of when combat finishes or the log is done and then throw errors for everything it maybe should have hit if the timeline kept running for X seconds?

Yeah also agree that if we get to a point where syncs have been missed and we've gone for X seconds, it should be more obvious. (Maybe in debug mode the timeline gets a red outline or something?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants