Doc number of search results is not available with secure search #4066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4066 +/- ##
========================================
Coverage 38.47% 38.47%
========================================
Files 717 717
Lines 33025 33025
Branches 4837 4665 -172
========================================
Hits 12706 12706
- Misses 19172 19695 +523
+ Partials 1147 624 -523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nl0
approved these changes
Aug 2, 2024
akarve
reviewed
Aug 4, 2024
| @@ -42,6 +42,8 @@ key that the user is not allowed to access will display an _Access Denied_ messa | |||
| * Prefix-aware search performs a head request on every object result; this may slow | |||
| search performance in the Catalog | |||
|
|
|||
| * Number of search results is not available with prefix-aware search | |||
There was a problem hiding this comment.
Suggested change
| * Number of search results is not available with prefix-aware search | |
| * The Catalog does not (accurately) display the number of search results |
There was a problem hiding this comment.
this limitation applies only to prefix-aware search aka secure search and you suggestion remove its mention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.