-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SignUp for mode="OPEN"
only
#3725
base: master
Are you sure you want to change the base?
Conversation
fiskus
commented
Sep 19, 2023
•
edited
Loading
edited
- Changelog entry (skip if change is not significant to end users, e.g. docs only)
passwordAuth
enabled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
========================================
Coverage 37.72% 37.72%
========================================
Files 766 766
Lines 35148 35148
Branches 5190 5190
========================================
Hits 13258 13258
+ Misses 21282 20658 -624
- Partials 608 1232 +624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
passwordAuth
enabledpasswordAuth
disabled
I think we need something more general here, such as a flag to disable the SignUp route via config.js? @dimaryaz can you comment? SignUp orthogonal to PasswordAuth, as even SSO stacks can sign up. The condition is more like in "PRODUCT" mode and under certain backend circumstances (sign up disabled, which is the common case) disable the route. |
ddeb295
to
3da048f
Compare
passwordAuth
disabledmode="OPEN"
only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is correct.
In the past, SSO sign up had a second step, where the user had to enter a username - but that's gone now, so the sign in page is all that's necessary.
…data/quilt into disable-signup-if-no-password-auth