Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SignUp for mode="OPEN" only #3725

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

fiskus
Copy link
Member

@fiskus fiskus commented Sep 19, 2023

  • Changelog entry (skip if change is not significant to end users, e.g. docs only)

@fiskus fiskus changed the title Disable SignUp if no passwordAuth enabled Disable SignUp if no passwordAuth enabled Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.72%. Comparing base (45070e6) to head (2354a09).

Files with missing lines Patch % Lines
catalog/app/containers/App/App.js 0.00% 1 Missing ⚠️
catalog/app/containers/Auth/PassReset.js 0.00% 1 Missing ⚠️
catalog/app/containers/Auth/SignIn.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3725    +/-   ##
========================================
  Coverage   37.72%   37.72%            
========================================
  Files         766      766            
  Lines       35148    35148            
  Branches     5190     5190            
========================================
  Hits        13258    13258            
+ Misses      21282    20658   -624     
- Partials      608     1232   +624     
Flag Coverage Δ
api-python 91.00% <ø> (ø)
catalog 12.12% <0.00%> (ø)
lambda 87.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fiskus fiskus requested review from akarve and nl0 September 19, 2023 10:28
@fiskus fiskus changed the title Disable SignUp if no passwordAuth enabled Disable SignUp if passwordAuth disabled Sep 19, 2023
nl0
nl0 previously approved these changes Sep 19, 2023
@akarve
Copy link
Member

akarve commented Sep 19, 2023

I think we need something more general here, such as a flag to disable the SignUp route via config.js? @dimaryaz can you comment?

SignUp orthogonal to PasswordAuth, as even SSO stacks can sign up. The condition is more like in "PRODUCT" mode and under certain backend circumstances (sign up disabled, which is the common case) disable the route.

@fiskus fiskus force-pushed the disable-signup-if-no-password-auth branch from ddeb295 to 3da048f Compare September 28, 2023 08:23
@fiskus fiskus changed the title Disable SignUp if passwordAuth disabled Enable SignUp for mode="OPEN" only Sep 28, 2023
dimaryaz
dimaryaz previously approved these changes Sep 28, 2023
Copy link
Contributor

@dimaryaz dimaryaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct.

In the past, SSO sign up had a second step, where the user had to enter a username - but that's gone now, so the sign in page is all that's necessary.

akarve
akarve previously approved these changes Sep 28, 2023
@fiskus fiskus dismissed stale reviews from akarve and dimaryaz via 42171e5 October 17, 2023 12:00
@fiskus fiskus enabled auto-merge October 17, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants