Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Macro compatibility #425

Closed
KaruroChori opened this issue Jun 6, 2024 · 2 comments
Closed

C++ Macro compatibility #425

KaruroChori opened this issue Jun 6, 2024 · 2 comments

Comments

@KaruroChori
Copy link
Contributor

KaruroChori commented Jun 6, 2024

Following the trail of #422, to improve the wider compatibility with C++ some macros would require minimal rework.

https://github.com/quickjs-ng/quickjs/blob/22c10224ac9885051ada62ac11a1d6e55593042b/quickjs.h#L960C1-L975C145

For reference, an equivalent problem discussed in saghul/txiki.js#535

@chqrlie
Copy link
Collaborator

chqrlie commented Jun 6, 2024

This seems a good change. This allows a C++ module to define an array of properties using these macros without an explicit extern C++ tag.

@KaruroChori
Copy link
Contributor Author

#428

@saghul saghul closed this as completed in 6efe30b Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants