Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a buffered channel in the acceptQueue #53

Merged
merged 1 commit into from
Dec 8, 2022
Merged

use a buffered channel in the acceptQueue #53

merged 1 commit into from
Dec 8, 2022

Commits on Dec 8, 2022

  1. use a buffered channel in the acceptQueue 

    There's a race condition here. A user might call Next to obtain the next
stream, and get a nil result. He then calls Chan get notified about new
incoming streams. If a new stream is accepted between the call to Next and the
call to Chan, he won't be notified about that stream, unless the channel is
buffered.
    @marten-seemann
    marten-seemann committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    63db3df View commit details
    Browse the repository at this point in the history