Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quic-go dependency #160

Closed
wants to merge 2 commits into from
Closed

Conversation

fasmat
Copy link

@fasmat fasmat commented Oct 17, 2024

The current version of webtransport is not compatible any more with the newest version of quic-go.

This PR updates the dependency and fixes uses of deprecated functions/types.

@fasmat
Copy link
Author

fasmat commented Oct 17, 2024

@marten-seemann let me know if you want me to adjust the PR in some way 🙂

go.mod Outdated Show resolved Hide resolved
@fasmat fasmat deleted the update-quic-go branch October 18, 2024 07:48
@fasmat
Copy link
Author

fasmat commented Oct 18, 2024

I don't understand why go 1.22.0 in the go.mod file isn't correct? go mod tidy is a no-op and go build and go test pass without errors.

I believe the problem is this step in the CI: https://github.com/ipdxco/unified-github-workflows/blob/61bc2a929b1a896da9559d6c4b14c574425da364/.github/workflows/go-check.yml#L36-L41

actions/setup-go@v5 supports parsing the go file from go.mod directly without having to read it manually in a separate step:

      - name: Set up the Go version read from the go.mod file
        uses: actions/setup-go@v5
        with:
          go-version-file: "release/go/go.mod"

Not specifying a minor version for the go directive in the go.mod file will sometimes cause go mod tidy to add one (and possibly a toolchain directive).

@fasmat
Copy link
Author

fasmat commented Oct 18, 2024

Still, I should thank you to for still putting effort into this 🙂

@marten-seemann
Copy link
Member

Not specifying a minor version for the go directive in the go.mod file will sometimes cause go mod tidy to add one (and possibly a toolchain directive).

No it doesn't. See my PR, which was checked for go mod tidy consistency.

@marten-seemann
Copy link
Member

I believe the problem is this step in the CI: https://github.com/ipdxco/unified-github-workflows/blob/61bc2a929b1a896da9559d6c4b14c574425da364/.github/workflows/go-check.yml#L36-L41

If I was still maintaining this repo, I'd migrate away from these workflows. But since I'm currently not, everything will remain as is for now.

@fasmat
Copy link
Author

fasmat commented Oct 18, 2024

Not specifying a minor version for the go directive in the go.mod file will sometimes cause go mod tidy to add one (and possibly a toolchain directive).

No it doesn't. See my PR, which was checked for go mod tidy consistency.

I don't know what you changed in your PR, but this failed to merge after you removed the minor version because go mod tidy added it back:

https://github.com/quic-go/webtransport-go/actions/runs/11396164669/job/31709549949#step:9:1

The same happens on my machine when I remove it and call go mod tidy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants