introduce a separate queue for undecryptable packets #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should prioritize the decryption of previously undecryptable packets, every time a new encryption level becomes available. This is achieved by introducing a separate queue instead of just putting the packets back into the receivedPackets channel. This also allows us to only count every received packet once for the amplification limit.
Codecov Report
@@ Coverage Diff @@
## master #2988 +/- ##
==========================================
- Coverage 86.12% 86.05% -0.07%
==========================================
Files 135 135
Lines 9379 9389 +10
==========================================
+ Hits 8077 8079 +2
- Misses 943 950 +7
- Partials 359 360 +1
Continue to review full report at Codecov.
|
lucas-clemente
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should prioritize the decryption of previously undecryptable packets, every time a new encryption level becomes available. This is achieved by introducing a separate queue instead of just putting the packets back into the
receivedPacketschannel.This also allows us to only count every received packet once for theamplification limit => fixes #2931.