Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example with lfs #104

Closed
wants to merge 1 commit into from
Closed

Update example with lfs #104

wants to merge 1 commit into from

Conversation

bevsxyz
Copy link

@bevsxyz bevsxyz commented Apr 4, 2024

Github doesn't load lfs tracked files unless mentioned in the actions explicitely

Github doesn't load lfs tracked files unless mentioned in the actions explicitely
@bevsxyz
Copy link
Author

bevsxyz commented Apr 4, 2024

I got the help from https://discourse.gohugo.io/t/github-pages-git-lfs/34217/3

I think we will also need to update the documentations

@cderv
Copy link
Collaborator

cderv commented Apr 4, 2024

Hi, thanks for your contribution

Git LFS is quite specific and advanced usage IMO. I am not sure this is a good idea to set this by default in the example, as it could lead to confusion about "is LFS needed with Quarto ?".

The configuration about lfs: true is related to configuration available for actions/checkout and it should be documented there. We may add a comment though using LFS with Quarto is possible: Do you have an example repo to share ?

Thank you

@bevsxyz
Copy link
Author

bevsxyz commented Apr 6, 2024

The code for my website is private ATM. I'll see if I can whip up another repo for example. But basically, if you intend to use git lfs and have already configured it, then without that flag the images won't be copied to gh-pages. I had git-lfs already present before transitioning from hugo. So it was frustrating as to why images weren't loading through ci.

@cderv
Copy link
Collaborator

cderv commented Apr 8, 2024

Oh sure I understand that it could be private. I understand why it could puzzling when you don't know this configuration from actions/checkout. I'll see where I can add a note to this. I don't think we should set the default to TRUE for this setting as it is not the default in the original action.

@cderv cderv added the documentation Improvements or additions to documentation label Apr 8, 2024
@bevsxyz
Copy link
Author

bevsxyz commented Apr 20, 2024

@cderv we can set it to false with a comment

@cderv cderv closed this in 13a0dde Apr 23, 2024
@cderv
Copy link
Collaborator

cderv commented Apr 23, 2024

I added a mention in the README about this, as a FAQ question.

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants