-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto Publish action fails when format: pdf is defined in _quarto.yml #41
Comments
Thanks a lot for this report. It seems setting the |
By the way, the first errors in your actions
are because using |
Commenting out the |
Thanks for the precision, I will look into that then. You have HTML also activated so I thought it was linked. I'll try to reproduce
We mention this very briefly in this document : Publish action seems magic because it will render for you... but to all format. This is a simplification we did for v2, and the v1 examples of the action were simplified. For a single format, you just need to adopt a two step process:
|
@cderv Let's figure out a way to make v2 support single formats |
I see two main ways:
I think the latter would work right ? The former is a bigger change in the CLI, but I can think of some usage were |
Hm, I misunderstood your earlier message. We already support "render: false". So all we need to do is update the documentation. |
Even more to the point, our documentation already mentions this workflow as well. We need to make this more prominent. |
I made a number of tweaks to the documentation so we have explicit mentions of single-format rendering now. |
Ok. So the two step process is indeed the way with the two actions. That is fine ! Thanks for the update to the doc |
We just have two places I think that we may need to merge:
I added mention to this already last time it was asked, but I will update based on your recent change. Maybe we should merge both examples |
for easier discovery as it was already hidden in two places. Related to #41
for easier discovery as it was already hidden in two places. Related to #41
for easier discovery as it was already hidden in two places. Related to #41
OK, I redid my publish.yml and _quarto.yml as you suggested above (at https://github.com/quarto-dev/quarto-actions/blob/main/examples/example-07-publish-single-format.md). It seems to work although I am still seeing the jsonlite errors.
|
You still seem to have
|
You're right - I disabled code-link and now it builds without error. There is a warning about a Thanks for all the help! |
I followed all of the instructions for setting up the GitHub Action for publishing (with frozen computations) from https://quarto.org/docs/publishing/github-pages.html#github-action. This failed however with the same error reported in #29 (see this failed run for instance). I solved it by removing the pdf format from my
_quarto.yml
per the suggestion by @clente on that issue.https://github.com/quanteda/Text-Analysis-Using-R/blob/24b0a189d9a0075ea60ad48b00076ccfa8bc79dd/_quarto.yml#L75-L87
But then in RStudio, the menu option to build the pdf version disappears, which is a shame. It would be nice to retain this option but be able to define the quarto render/publish actions in https://github.com/quarto-dev/quarto-actions/blob/main/publish/action.yml to render HTML only.
Thanks for such an amazing piece of software!! 👏🙏👏
The text was updated successfully, but these errors were encountered: