Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS MSSQL test in FIPS-enabled environment and disable non-TLS MSSQL tests in FIPS-enabled environment #2097

Merged

Conversation

michalvavrik
Copy link
Member

Summary

Looks like secured communication is required and cannot be disabled in MSSQL JDBC driver by no means I had tried based on https://learn.microsoft.com/en-us/sql/connect/jdbc/fips-mode?view=sql-server-ver16 (no, FIPS property doesn't work). I have tried several providers including SunPKCS11 with RH OpenJDK 17/21 and BouncyCastle FIPS, but only provider that did the trick for MSSQL JDBC driver was BouncyCastle JSSE FIPS. However this provide is not native compatible as documented here https://quarkus.io/guides/security-customization#bouncy-castle-jsse-fips (I tried it, doesn't work). So what this PR does:

  • we have one TLS MSSQL test, that is migrated to BC JSSE FIPS so that we test MSSQL in FIPS-enabled environment
  • remaining MSSQL tests that doesn't use secured communication are disabled in FIPS as native is more important

Note: I tried to migrate all the SQL Server tests to the BC JSSE FIPS and it works.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@gtroitsk gtroitsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants