Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OCP config map name unique for same mount paths #992

Merged

Conversation

michalvavrik
Copy link
Member

Summary

fixes:

  • config map name is not unique when more than one file is mounted to same directory
  • /etc/|server-keystore.jks was mounted to /etc//server-keystore.jks, now it is /etc/server-keystore.jks

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! It§s look good just one thing. Can you use joinMountPathAndFileName also here https://github.com/quarkus-qe/quarkus-test-framework/pull/992/files#diff-8a361a4b7ddbed5806dc8db9f66279da5238c3d66406b50ed40aa90a8b708d74L858

@michalvavrik michalvavrik force-pushed the feature/fix-ocp-config-name-path branch from 40c0dd7 to 251e555 Compare December 19, 2023 15:45
@michalvavrik
Copy link
Member Author

Thanks for this PR! It§s look good just one thing. Can you use joinMountPathAndFileName also here https://github.com/quarkus-qe/quarkus-test-framework/pull/992/files#diff-8a361a4b7ddbed5806dc8db9f66279da5238c3d66406b50ed40aa90a8b708d74L858

done

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update! LGTM!

@michalvavrik
Copy link
Member Author

Thanks for update! LGTM!

Thank you, I'll just wait for validate format step to pass as I don't want to wait for whole CI again. I have other PR on the way changing related code, you will see CI there today.

@jedla97
Copy link
Member

jedla97 commented Dec 19, 2023

Thank you, I'll just wait for validate format step to pass as I don't want to wait for whole CI again. I have other PR on the way changing related code, you will see CI there today.

Np as it pass last time I don't think this change cause any problem. So I'm ok with it

@michalvavrik michalvavrik merged commit 2ed2005 into quarkus-qe:main Dec 19, 2023
3 of 5 checks passed
@michalvavrik michalvavrik deleted the feature/fix-ocp-config-name-path branch December 19, 2023 16:04
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants