-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Quarkus Maven plugin to build native executables #971
Use Quarkus Maven plugin to build native executables #971
Conversation
run tests |
371b8ac
to
964e524
Compare
run tests |
964e524
to
8a2eeaf
Compare
run tests |
I think remaining OCP native failures goes down to the fact that |
Remaining system properties are propagated anyway, so |
Ah, or I decided to not propagate non-Quarkus system props I think, yeah, still should be that, logs, images and |
The safest way would be to propagate whole previous command, I'll check if I can somehow determine that. |
I've checked - it is possible to do this safely via |
cf2b0a8
to
0dc098d
Compare
Okay, I think I got it. We can probably make it more robust in the future, but I think it will work for current use cases. Let's see. |
run tests |
0dc098d
to
2e932a4
Compare
run tests |
2e932a4
to
0e1703d
Compare
0e1703d
to
e278f25
Compare
run tests |
@rsvoboda all green now :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Fact that (so far) #949 fixed win race issue when building native executable on Windows tells me that by using
QuarkusBootstrap
class directly we just hope our setup is same as Quarkus Maven plugin is using. Users will have native executable built by Quarkus maven plugin, and so should we.Please check the relevant options
run tests
phrase in comment)Checklist: