Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quarkus Maven plugin to build native executables #971

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Dec 1, 2023

Summary

Fact that (so far) #949 fixed win race issue when building native executable on Windows tells me that by using QuarkusBootstrap class directly we just hope our setup is same as Quarkus Maven plugin is using. Users will have native executable built by Quarkus maven plugin, and so should we.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch from 371b8ac to 964e524 Compare December 22, 2023 10:36
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch from 964e524 to 8a2eeaf Compare December 22, 2023 11:52
@michalvavrik michalvavrik marked this pull request as ready for review December 22, 2023 11:53
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

I think remaining OCP native failures goes down to the fact that maven.repo.local needs to be propagated. It should be easy to do, I'll do it and test it.

@michalvavrik
Copy link
Member Author

Remaining system properties are propagated anyway, so maven specific args are special-case.

@michalvavrik
Copy link
Member Author

Ah, or I decided to not propagate non-Quarkus system props I think, yeah, still should be that, logs, images and ts props.

@michalvavrik
Copy link
Member Author

The safest way would be to propagate whole previous command, I'll check if I can somehow determine that.

@michalvavrik
Copy link
Member Author

I've checked - it is possible to do this safely via ProcessHandle API, I'll propagate exactly -D used in the original command.

@rsvoboda rsvoboda self-requested a review December 22, 2023 13:42
@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch 2 times, most recently from cf2b0a8 to 0dc098d Compare December 22, 2023 14:25
@michalvavrik
Copy link
Member Author

Okay, I think I got it. We can probably make it more robust in the future, but I think it will work for current use cases. Let's see.

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch from 0dc098d to 2e932a4 Compare December 22, 2023 14:30
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch from 2e932a4 to 0e1703d Compare December 22, 2023 14:48
@michalvavrik michalvavrik force-pushed the feature/use-maven-native-exec-build-strategy branch from 0e1703d to e278f25 Compare December 22, 2023 14:48
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

@rsvoboda all green now :-)

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsvoboda rsvoboda merged commit d2603d1 into quarkus-qe:main Dec 22, 2023
9 checks passed
@michalvavrik michalvavrik deleted the feature/use-maven-native-exec-build-strategy branch December 22, 2023 21:34
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants