Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated jvm and native Dockerfiles #537

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Updated jvm and native Dockerfiles #537

merged 1 commit into from
Aug 24, 2022

Conversation

jirisimek98
Copy link
Contributor

Updated Dockerfiles since the outdated ones have issues running on OCP 4.11

@rsvoboda rsvoboda requested a review from pjgg August 18, 2022 13:25
@mjurc mjurc mentioned this pull request Aug 18, 2022
Closed
9 tasks
pjgg
pjgg suggested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@pjgg pjgg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jirisimek98 for your PR, just a few comments

quarkus-test-images/src/main/resources/Dockerfile.jvm Outdated Show resolved Hide resolved
quarkus-test-images/src/main/resources/Dockerfile.native Outdated Show resolved Hide resolved
@mjurc mjurc assigned mjurc and jirisimek98 and unassigned mjurc Aug 22, 2022
@mjurc mjurc self-requested a review August 22, 2022 08:04
@fedinskiy fedinskiy self-requested a review August 22, 2022 14:47
@jirisimek98 jirisimek98 requested review from pjgg and removed request for mjurc and fedinskiy August 23, 2022 08:53
@fedinskiy fedinskiy requested review from fedinskiy and removed request for pjgg August 23, 2022 08:58
fedinskiy
fedinskiy approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait for CI

And could you bring back that newline at the end of Dockerfile.native? :-)

@fedinskiy
Copy link
Contributor

run tests

1 similar comment
@fedinskiy
Copy link
Contributor

run tests

mjurc
mjurc approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated.

LGTM, thanks for the update!

@mjurc mjurc merged commit 0b446b8 into quarkus-qe:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjgg pjgg pjgg requested changes

@mjurc mjurc mjurc approved these changes

@fedinskiy fedinskiy fedinskiy approved these changes

Assignees

@jirisimek98 jirisimek98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jirisimek98 @fedinskiy @pjgg @mjurc