-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated jvm and native Dockerfiles #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jirisimek98 for your PR, just a few comments
853ec6f
to
c66ce09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but let's wait for CI
And could you bring back that newline at the end of Dockerfile.native? :-)
PR comments newline
c66ce09
to
3bcf90a
Compare
run tests |
1 similar comment
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI failures are unrelated.
LGTM, thanks for the update!
Updated Dockerfiles since the outdated ones have issues running on OCP 4.11