Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple gRPC from Test core #515

Merged

Conversation

michalvavrik
Copy link
Member

Summary

fixes: #359

Once merged, we have to add quarkus-test-service-grpc to the http-advanced and http-advanced-reactive modules of the QE Test Suite.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik requested a review from pjgg July 13, 2022 12:09
@michalvavrik michalvavrik self-assigned this Jul 13, 2022
<dependencies>
<dependency>
<groupId>io.quarkus.qe</groupId>
<artifactId>quarkus-test-core</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope provided?
<scope>provided</scope>

@pjgg pjgg merged commit b68b3f2 into quarkus-qe:main Jul 15, 2022
@michalvavrik michalvavrik deleted the feature/decouple-grpc-from-test-core branch July 15, 2022 13:22
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jul 19, 2022
Bumps Quarkus Test Framework from 1.2.0.Beta1 to 1.2.0.Beta2 and adds `quarkus-test-service-grpc` to modules `http/http-advanced` and `http/http-advanced-reactive` as gRPC [has recently been decoupled](quarkus-qe/quarkus-test-framework#515) from `quarkus-test-core`.
pjgg pushed a commit to quarkus-qe/quarkus-test-suite that referenced this pull request Jul 19, 2022
Bumps Quarkus Test Framework from 1.2.0.Beta1 to 1.2.0.Beta2 and adds `quarkus-test-service-grpc` to modules `http/http-advanced` and `http/http-advanced-reactive` as gRPC [has recently been decoupled](quarkus-qe/quarkus-test-framework#515) from `quarkus-test-core`.
@michalvavrik michalvavrik mentioned this pull request Jul 20, 2022
9 tasks
michalvavrik added a commit to michalvavrik/quarkus-test-suite that referenced this pull request Jul 20, 2022
Bumps Quarkus Test Framework from 1.1.0.Final to 1.1.1.Final and adds `quarkus-test-service-grpc` to modules `http/http-advanced` and `http/http-advanced-reactive` as gRPC [has recently been decoupled](quarkus-qe/quarkus-test-framework#515) from `quarkus-test-core`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-test-core brings grpc-api as a transitive dependency
2 participants