Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Windows/oracle native compilation #496

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jun 22, 2022

Summary

Diable windows/oracle example on native mode.
Issue: quarkusio/quarkus#25954

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg requested a review from rsvoboda June 22, 2022 07:56
@@ -61,6 +61,15 @@
</build>
<profiles>
<!-- Skipped on Windows as does not support Linux Containers / Testcontainers -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment belongs to skip-tests-on-windows profile

examples/database-oracle/pom.xml Show resolved Hide resolved
<quarkus.package.type>fast-jar</quarkus.package.type>
</properties>
</profile>
<!-- TODO https://github.com/quarkusio/quarkus/issues/25954 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- TODO https://github.com/quarkusio/quarkus/issues/25954 -->
<!-- Skipped on Windows as does not support Linux Containers / Testcontainers -->

@rsvoboda rsvoboda merged commit aa18a79 into quarkus-qe:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants