Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicit reusable container verification example #490

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Add an explicit reusable container verification example #490

merged 2 commits into from
Jun 21, 2022

Conversation

pjgg
Copy link
Contributor

@pjgg pjgg commented Jun 17, 2022

Summary

  • Rename DevServicesOnDevModeMySqlDatabaseIT -> DevModeMySqlDevServicesDatabaseIT
  • Reusable container should not force a close event on docker container service.
  • Add a explicit verification of reusable containers.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@pjgg pjgg requested a review from mjurc June 17, 2022 15:54
@mjurc
Copy link
Member

mjurc commented Jun 20, 2022

@pjgg can you check the failures?

mjurc
mjurc reviewed Jun 21, 2022
View reviewed changes
Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjurc mjurc merged commit 624e383 into quarkus-qe:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjurc mjurc mjurc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjgg @mjurc