Add closing resources in quarkus cli as windows is more strict

[jedla97]

Summary

When running update tes coverage on windows, the resources were not closed and blocking deletion of file and directories. Probably Windows is more strict on this that this was not caught on Linux.

Also even if I dind't see any usage of readYamlFileIntoProperties (actual method which use it is checkYamlPropertiesUpdate but didn't find it in framework or testsuite). I also add try-with-resources for it as it can be problematic in future.

Tested it localy on AWS windows

Please check the relevant options

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Dependency update
• Refactoring
• Release (follows conventions described in the RELEASE.md)
• Breaking change (fix or feature that would cause existing functionality to change)
• This change requires a documentation update
• This change requires execution against OCP (use run tests phrase in comment)

Checklist:

• Example scenarios has been updated / added
• Methods and classes used in PR scenarios are meaningful
• Commits are well encapsulated and follow the best practices

[mocenas]

Hmm, I would assume that garbage collector would make a quick work of that open files, no matter what OS is it on. But this is probably better.

BTW: Yaml properties are used here - https://github.com/quarkus-qe/quarkus-test-suite/blob/3.8/quarkus-cli/src/test/java/io/quarkus/ts/quarkus/cli/update/Quarkus32to38CliUpdateIT.java#L77 It is not in main TS branch (no actual update test are).

[mocenas]

LGTM. Let's just wait for the CI.

[rsvoboda]

Garbage collector doesn't help with open files. Windows/NTFS has more strict file access and thus the need for try-with-resources or explicit close. Windows forces proper code wrt file system (one can complain it's less nice, but that's Java syntax).