Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tls-registry extension from CLI and update management TLS note #1330

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Remove tls-registry extension from CLI and update management TLS note #1330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0419d1a
Remove `tls-registry` extension from default aplication request for T…
jedla97 Sep 18, 2024
626955a
Change description/TODO note of management TLS tests
jedla97 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/management/src/test/java/io/quarkus/qe/LocalTLSIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import io.restassured.response.Response;

@QuarkusScenario
// todo Merge with LocalIT when https://github.com/quarkusio/quarkus/issues/32225 is fixed
// todo Merge with LocalIT when framework support SSL/TLS on openshift https://github.com/quarkus-qe/quarkus-test-framework/issues/1052
public class LocalTLSIT {

@QuarkusApplication(certificates = @Certificate(configureManagementInterface = true, configureKeystore = true, useTlsRegistry = false))
Expand Down
4 changes: 2 additions & 2 deletions examples/management/src/test/java/io/quarkus/qe/OpenShiftTLSIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import io.quarkus.test.scenarios.OpenShiftScenario;

@OpenShiftScenario
@Disabled
// todo delete when https://github.com/quarkusio/quarkus/issues/32225 is fixed
@Disabled("https://github.com/quarkus-qe/quarkus-test-framework/issues/1052")
// todo delete when framework support SSL/TLS on openshift
public class OpenShiftTLSIT extends LocalTLSIT {
}
3 changes: 1 addition & 2 deletions quarkus-test-cli/src/main/java/io/quarkus/test/bootstrap/tls/QuarkusTlsCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ QuarkusCliCommandResult runTlsCommand(List<String> subCmdArgs) {

private static QuarkusCliClient.CreateApplicationRequest getCreateAppReq() {
return QuarkusCliClient.CreateApplicationRequest.defaults()
// TODO: we can drop 'tls-registry' when https://github.com/quarkusio/quarkus/issues/42751 is fixed
.withExtensions("tls-registry", "quarkus-rest");
.withExtensions("quarkus-rest");
}

private static File createTempDir() {
Expand Down