Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PostgreSQL waiting strategy for image from Red Hat container registry #1305

Conversation

michalvavrik
Copy link
Member

Summary

Here https://github.com/sclorg/postgresql-container/blob/master/16/root/usr/share/container-scripts/postgresql/README.md?plain=1#L74 they say it's for errors but I think it's just strange terminology of PG or something else I don't understand. Logged messages IMHO belongs to STD OUT, let's see:

21:01:27,390 INFO  [database] 2024-09-12 19:01:25.709 UTC [1] LOG:  redirecting log output to logging collector process
21:01:27,391 INFO  [database] 2024-09-12 19:01:25.709 UTC [1] HINT:  Future log output will appear in directory "/dev".
21:01:27,391 INFO  [database] 2024-09-12 19:01:25.709 UTC [1] LOG:  starting PostgreSQL 16.4 on x86_64-redhat-linux-gnu, compiled by gcc (GCC) 11.4.1 20231218 (Red Hat 11.4.1-3), 64-bit
21:01:27,391 INFO  [database] 2024-09-12 19:01:25.710 UTC [1] LOG:  listening on IPv4 address "0.0.0.0", port 5432
21:01:27,391 INFO  [database] 2024-09-12 19:01:25.710 UTC [1] LOG:  listening on IPv6 address "::", port 5432
21:01:27,391 INFO  [database] 2024-09-12 19:01:25.710 UTC [1] LOG:  listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432"
21:01:27,392 INFO  [database] 2024-09-12 19:01:25.710 UTC [1] LOG:  listening on Unix socket "/tmp/.s.PGSQL.5432"
21:01:27,392 INFO  [database] 2024-09-12 19:01:25.713 UTC [64] LOG:  database system was shut down at 2024-09-12 19:01:25 UTC
21:01:27,392 INFO  [database] 2024-09-12 19:01:25.717 UTC [1] LOG:  database system is ready to accept connections

These log messages go to STD OUT with property I am adding in this PR.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@mjurc mjurc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik added triage/backport-1.4? Quarkus 3.8 stream triage/backport-1.5? Quarkus 3.15 stream labels Sep 12, 2024
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik merged commit 4264e4c into quarkus-qe:main Sep 12, 2024
9 of 10 checks passed
@michalvavrik michalvavrik deleted the feature/fix-rh-postgresql-logging-strategy branch September 12, 2024 21:31
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 13, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement reliable container waiting strategy for OpenShift PostgreSQL images from Red Hat registry
2 participants