Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop debugging options for Windows native race #1297

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Sep 10, 2024

Summary

I added it when we experienced race in Windows native build, but the race was fixed with Quarkus Maven plugin build strategy, so we don't need this anymore.

Additional motivation is to drop only instance of JBOSS logger we have in our FW.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik added triage/backport-1.4? Quarkus 3.8 stream triage/backport-1.5? Quarkus 3.15 stream labels Sep 10, 2024
@michalvavrik
Copy link
Member Author

loosely related to #1298, I don't think this is necessary, but still would like to drop this code

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@jedla97 jedla97 merged commit 2a47f91 into quarkus-qe:main Sep 10, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/drop-windows-native-race-debug-options branch September 11, 2024 07:03
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Sep 13, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants