Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isRHBQ method to check if the version contain string redhat #1294

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

TimonCzech
Copy link

Summary

Added a new method called is isRHBQ that replaces QuarkusProperties.getVersion().contains("redhat") and replaces it's usage

Fixes :#1215

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

Copy link
Member

@jedla97 jedla97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Changes looks good to me. Lets wait CI have to say

@jedla97
Copy link
Member

jedla97 commented Sep 9, 2024

CI error is not related. It's QuarkusCliClientIT.shouldCreateExtension affected by latest update of Quarkus

@jedla97 jedla97 merged commit 7413aff into quarkus-qe:main Sep 9, 2024
7 of 8 checks passed
@mocenas mocenas added the triage/backport-1.4? Quarkus 3.8 stream label Sep 12, 2024
@michalvavrik michalvavrik removed the triage/backport-1.4? Quarkus 3.8 stream label Sep 13, 2024
@mocenas mocenas added the triage/backport-1.5? Quarkus 3.15 stream label Sep 17, 2024
@mocenas mocenas mentioned this pull request Sep 17, 2024
12 tasks
@fedinskiy fedinskiy mentioned this pull request Oct 7, 2024
12 tasks
@fedinskiy fedinskiy removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce helper method "isRHBQ()" to differentiate between upstream and RH build
5 participants