Add release version checker to GitHub Actions workflow #1061
Conversation
gtroitsk
force-pushed
the
release-version-checker
branch
from
1e85a64
to
3b2d580
Compare
gtroitsk
changed the title
|
@michalvavrik I need to check new error messages. I will provide you with the links to gh actions runs |
gtroitsk
force-pushed
the
release-version-checker
branch
from
3b2d580
to
c858108
Compare
1.4.2.Final -> 1.4.3.Beta1 1.4.2.Beta8 -> 1.4.2.Beta10 |
| @@ -0,0 +1,41 @@ | |||
| name: Check release version | |||
| on: | |||
| push: | |||
There was a problem hiding this comment.
Isn't push a bit too late/early? This should ideally happen in PR, right? I am not sure if push actions are visualized in PRs
There was a problem hiding this comment.
Good point, changed to trigger job only in PR
There was a problem hiding this comment.
I don't agree it is too late. You want to run this when change on that file happens and that happens when push happens... You can see that in the PR actions. Anyway, reading https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#push https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request there is no practical difference as Georgii added condition on that file change. I am fine with change, just that I don't agree with previous comments.
There was a problem hiding this comment.
If the push action is visible on PR, I have no issue with it being on push at all. I just wasn't sure
There was a problem hiding this comment.
yeah, me neither, that's why asked Georgii for a proof, I probably asked him on the Slack and it's not recorded here, sorry. anyway, let's keep this.
gtroitsk
force-pushed
the
release-version-checker
branch
from
c858108
to
d07c4b2
Compare
|
Thanks a lot @gtroitsk |
|
It looks like we missed the case, there we have two release streams (beta and release) in parallel. I am trying to release 1.5.0.Beta7, but we have 1.4.7 release after 1.5.0.Beta6, and so there is this error: |
|
@fedinskiy I will create QQE, I have no time to fix it this week |
|
Yeah, the point is that this scrip is using 'latest' tag and only releases are marked as latest, not pre-releases. it started failing when I unmarked all the prereleases as "not latest" and not "releases". +1 for na QQE task |
Summary
Add release versioning check to GH Actions workflow. When user change project.yaml
check-release-versionjob is triggeredIf the new version is wrong, job fails with error message
Example PR and test runs. I add debug print to print from what version to what version FW bumps, for example (1.4.2.Beta8 -> 1.4.2.Beta10)
gtroitsk#1
Success: 1.4.2.Beta8 -> 1.4.2.Beta9
(https://github.com/gtroitsk/quarkus-test-framework/actions/runs/8185766438/job/22382750464?pr=1)
Success: 1.4.2.Final -> 1.4.3.Beta1
(https://github.com/gtroitsk/quarkus-test-framework/actions/runs/8185802974/job/22382862356?pr=1)
Failure: 1.4.2.Beta8 -> 1.4.2.Beta10
(https://github.com/gtroitsk/quarkus-test-framework/actions/runs/8185784491/job/22382806672?pr=1)
Failure: 1.4.2.Final -> 1.4.3.Beta2
(https://github.com/gtroitsk/quarkus-test-framework/actions/runs/8185818924/job/22382914371?pr=1)
Failure: 1.4.2.Final -> 1.4.4.Beta1
(https://github.com/gtroitsk/quarkus-test-framework/actions/runs/8185827502/job/22382941018?pr=1)
Please check the relevant options
run testsphrase in comment)Checklist: