Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily action - rename artifacts to just maven repo #1004

Merged

Conversation

mocenas
Copy link
Contributor

@mocenas mocenas commented Jan 2, 2024

Summary

This PR reverts change on daily.yaml made in #1000

Currently the downloaded artifacts are named maven-repo-, which does not correspond to the one uploaded artifact "maven-repo". It leads to actions failing on non-found artifact. See e.g. https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/7304561952/job/19907115554 which fails on e.g. :
Error: Unable to download artifact(s): Artifact not found for name: maven-repo-windows-build-native

Original reason for making the names unique was to fulfill https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md . Which states that artifact with one name can only be uploaded once on upload-artifact@v4. But we're uploading the artifact only once on

- name: Persist Maven Repo

All other occurrences are for downloading the artifact. Therefore there is no need to make the name unique. On the contrary we need the name on downloads to match the name on the upload.

I tried this change here: https://github.com/mocenas/quarkus-test-framework/actions/runs/7384969337/job/20089159569
Pipeline still failed on something, but it fixed the issue with artifact download.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jcarranzan jcarranzan merged commit f265d85 into quarkus-qe:main Jan 2, 2024
7 checks passed
@mocenas mocenas deleted the revert_maven_repo_download_renaming branch January 2, 2024 13:51
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants