Fix daily action - rename artifacts to just maven repo #1004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reverts change on daily.yaml made in #1000
Currently the downloaded artifacts are named maven-repo-, which does not correspond to the one uploaded artifact "maven-repo". It leads to actions failing on non-found artifact. See e.g. https://github.com/quarkus-qe/quarkus-test-framework/actions/runs/7304561952/job/19907115554 which fails on e.g. :
Error: Unable to download artifact(s): Artifact not found for name: maven-repo-windows-build-native
Original reason for making the names unique was to fulfill https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md . Which states that artifact with one name can only be uploaded once on upload-artifact@v4. But we're uploading the artifact only once on
quarkus-test-framework/.github/workflows/daily.yaml
Line 32 in 2056dcd
All other occurrences are for downloading the artifact. Therefore there is no need to make the name unique. On the contrary we need the name on downloads to match the name on the upload.
I tried this change here: https://github.com/mocenas/quarkus-test-framework/actions/runs/7384969337/job/20089159569
Pipeline still failed on something, but it fixed the issue with artifact download.
Please check the relevant options
run tests
phrase in comment)Checklist: