-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating pygor from IGoR repo. #27
Comments
Hi Wout! Sorry for the long delay before my reply. Thank you very much for taking the lead on this one! Here are the pros and cons I see about this separation: Pros:
Cons:
Development directions:
Tell me if you have other ideas I will append them to the list! |
Hi Quentin, Sounds good! I have been taking some initiative on this one, since I needed to get started on doing some more of the master related work. Because of this I have cloned a version of pygor as one of my own repos (I made sure the your commit messages where carried over as well). You can find this version here: https://github.com/penuts7644/pygor and is installable via PyPI as well. I'm currently working on some refactoring work for the module (aka using more classes and separating the tools a bit more). I agree with your pros and cons and am willing to implement these as time progresses. Just not right now because of my own priorities. Also I think that the cons can be solved (for now) by mentioning which version of pygor works with which version of IGoR in the readme file of pygor (or even IGoR). Cython is really nice to implement for some speed improvements and I will also add some snippets for pythons own multiprocessing module (for example for pandas data frame manipulation tasks). Have a great day! Cheers, Wout |
Hi Quentin,
I created this separated issue (based on pull request #26) to continue our talk in pygor development.
Since I'm working a lot with IGoR and pygor at the moment (check out the following git repo: https://github.com/penuts7644/TcrDataComparison), I would like be more involved with the development of pygor and its codebase. Many of the code pieces I'm writing in the git repo above could be additions to pygor, especially when my thesis work progresses.
To make pygor and IGoR easier to maintain, I propose the following:
I would love to spend more of my time on the development process of pygor and I have no problem to take some initiative to set all of this up.
Please let me know what you think 😄
Cheers, Wout
The text was updated successfully, but these errors were encountered: