Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Numpy to the latest version in CI environment once UTF bug in PyTorch is fixed #815

Closed
edoaltamura opened this issue Jul 5, 2024 · 0 comments · Fixed by #816
Closed
Assignees
Labels
Connector: PyTorch 🔦 Relevant to optional packages, such as external connectors dependencies 🔗 Involves external dependency libraries type: ci 🔧 Related to Continuous Integration workflows
Milestone

Comments

@edoaltamura
Copy link
Collaborator

What should we add?

Revert the Numpy pinned version 1.x, done in #814, to the latest 2.x once PyTorch 2.2.2 can be released following the fix of pytorch/pytorch#124897.

The versions of Numpy and PyTorch were pinned because of the UTF-8 issue that breaks the Windows CI tests. However, PyTorch 2.2.2 is not compatible with Numpy 2.x, therefore requiring the pinning of Numpy to 1.x.

This issue can be resolved together with #797.

@edoaltamura edoaltamura added on hold 🛑 Can not fix yet type: ci 🔧 Related to Continuous Integration workflows dependencies 🔗 Involves external dependency libraries Connector: PyTorch 🔦 Relevant to optional packages, such as external connectors labels Jul 5, 2024
@edoaltamura edoaltamura self-assigned this Jul 5, 2024
@edoaltamura edoaltamura removed the on hold 🛑 Can not fix yet label Jul 15, 2024
@edoaltamura edoaltamura added this to the 0.8.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector: PyTorch 🔦 Relevant to optional packages, such as external connectors dependencies 🔗 Involves external dependency libraries type: ci 🔧 Related to Continuous Integration workflows
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant