This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Add support for Python 3.9 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-ignis. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9.
mtreinish
added
on hold
|
Marking this on hold because we'll add this after the next release. Also need to wait for CI to comeback to see which dependencies need to be updated. |
|
This should be good to go now. The only place we don't have coverage with this PR is windows on 3.9. This is because to run in CI we need to build aer from source (since it hasn't had a release with 3.9 support yet, but master has it). However, configuring ci to build aer from source on windows is more trouble than its worth so we can just wait to add that job until after aer releases. |
chriseclectic
approved these changes
Jan 13, 2021
mtreinish
added a commit
to mtreinish/aqua
that referenced
this pull request
Jan 14, 2021
Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-ignis. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071
mtreinish
added a commit
to mtreinish/aqua
that referenced
this pull request
Jan 14, 2021
Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-aqua. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071
manoelmarques
pushed a commit
to qiskit-community/qiskit-aqua
that referenced
this pull request
Jan 15, 2021
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-aqua. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. This follows on from Qiskit/qiskit#5189, qiskit-community/qiskit-ignis#505, and Qiskit/qiskit-aer#1071 * Add release note * Remove 3.9 tutorial job Jupyter on 3.9 doesn't have a good story yet, so just run tutorials on 3.6 and 3.8 for now. * Update optional requirement system constraints Co-authored-by: Steve Wood <40241007+woodsp-ibm@users.noreply.github.com>
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Jan 28, 2021
In qiskit-community#505 we added jobs for Python 3.9, but because there was no released Aer version that supported 3.9 yet to run tests we had to rely on building aer from source in test jobs to test that things worked as expected in CI. Now that Aer 0.7.3 has been released this included support for python 3.9, so we now don't need to rely on building aer from source in CI. This commit removes the job configuration to build Aer from source in the 3.9 jobs (both in the tox configuration and github actions config).
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Feb 5, 2021
* Add support for Python 3.9 Python 3.9.0 was released on 10-05-2020, this commits marks the support of Python 3.9 in qiskit-ignis. It adds the supported python version in the package metadata and updates the CI configuration to run test jobs on Python 3.9. * Build from master for aer 3.9 support * Split aer install into separate tox job * Use tox -epy39 for 3.9 jobs * Tweak gha condition * Fix 3.9 reverse conditions in gha config * Remove 3.9 windows job until aer release (cherry picked from commit fddd1e5)
chriseclectic
pushed a commit
that referenced
this pull request
Feb 8, 2021
* Use Aer from release for 3.9 test jobs In #505 we added jobs for Python 3.9, but because there was no released Aer version that supported 3.9 yet to run tests we had to rely on building aer from source in test jobs to test that things worked as expected in CI. Now that Aer 0.7.3 has been released this included support for python 3.9, so we now don't need to rely on building aer from source in CI. This commit removes the job configuration to build Aer from source in the 3.9 jobs (both in the tox configuration and github actions config). * Remove unecessary macOS job definition branch for 3.9
mtreinish
added a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
Feb 8, 2021
* Use Aer from release for 3.9 test jobs In qiskit-community#505 we added jobs for Python 3.9, but because there was no released Aer version that supported 3.9 yet to run tests we had to rely on building aer from source in test jobs to test that things worked as expected in CI. Now that Aer 0.7.3 has been released this included support for python 3.9, so we now don't need to rely on building aer from source in CI. This commit removes the job configuration to build Aer from source in the 3.9 jobs (both in the tox configuration and github actions config). * Remove unecessary macOS job definition branch for 3.9 (cherry picked from commit 9fd0edc)
jakelishman
added a commit
to jakelishman/qiskit-ignis
that referenced
this pull request
Jan 18, 2022
The original constraint was added in qiskit-communitygh-505, at a time when Aer was specifically requiring jupyter_sphinx in its own `requirements-dev.txt` under certain constraints. The constraint no longer appears to be needed, so all it serves to do now is to cause the docs build to fail on Python 3.9.
mtreinish
pushed a commit
that referenced
this pull request
Apr 11, 2022
The original constraint was added in gh-505, at a time when Aer was specifically requiring jupyter_sphinx in its own `requirements-dev.txt` under certain constraints. The constraint no longer appears to be needed, so all it serves to do now is to cause the docs build to fail on Python 3.9.
mtreinish
pushed a commit
to mtreinish/qiskit-ignis
that referenced
this pull request
May 17, 2022
The original constraint was added in qiskit-communitygh-505, at a time when Aer was specifically requiring jupyter_sphinx in its own `requirements-dev.txt` under certain constraints. The constraint no longer appears to be needed, so all it serves to do now is to cause the docs build to fail on Python 3.9. (cherry picked from commit 0e3716c)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.9.0 was released on 10-05-2020, this commits marks the support
of Python 3.9 in qiskit-ignis. It adds the supported python version in
the package metadata and updates the CI configuration to run test jobs
on Python 3.9.
Details and comments
Missing support: