This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
[Stable] Fixed partial trace constraint in cvx fitting routine (#438) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
added
the
Changelog: Bugfix
mtreinish
changed the title
chriseclectic
approved these changes
Jun 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #437
Details and comments
When doing process tomography with the cvx method, one can include a constraint s.t. the resulting quantum channel will be trace preserving. Mathematically this constraint corresponds to the partial trace of the Choi matrix being the identity.
In the code, only the real part of the partial trace is compared with the identity, but not the imaginary part.
Backported from #438
(cherry picked from commit 3b72172)