Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MNIST download for minor release #3559

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Fix MNIST download for minor release #3559

merged 2 commits into from
Mar 12, 2021

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Mar 12, 2021

No description provided.

seemethere and others added 2 commits March 12, 2021 07:46
@seemethere @fmassa @pmeier
datasets: Fallback to our own mirrors for mnist (pytorch#3544)
7c3527c 
We are experiencing 403s when trying to download from the main mnist
site so lets fallback to our own mirror on failure.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

Co-authored-by: Francisco Massa <fvsmassa@gmail.com>
@pmeier
Fix (Fashion|K)MNIST download and MNIST download test (pytorch#3557)
716bd49 
* add mirrors to (Fashion|K)MNIST

* fix download tests for MNIST
@pmeier pmeier requested a review from fmassa March 12, 2021 09:59
@pmeier pmeier requested a review from seemethere March 12, 2021 09:59
fmassa
fmassa approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Philip!

@codecov
Copy link

codecov bot commented Mar 12, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release/0.9@01dfa8e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/0.9    #3559   +/-   ##
==============================================
  Coverage               ?   75.93%           
==============================================
  Files                  ?      105           
  Lines                  ?     9726           
  Branches               ?     1561           
==============================================
  Hits                   ?     7385           
  Misses                 ?     1852           
  Partials               ?      489

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01dfa8e...716bd49. Read the comment docs.

@fmassa fmassa merged commit 0dbc7d8 into pytorch:release/0.9 Mar 12, 2021
@fmassa fmassa mentioned this pull request Mar 15, 2021
Closed
@pmeier pmeier deleted the mnist-mirror branch March 16, 2021 09:18
@akihironitta akihironitta mentioned this pull request May 6, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

@seemethere seemethere Awaiting requested review from seemethere

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmeier @fmassa @facebook-github-bot @seemethere