Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC - how do we import v2 namespaces and datapoints #7866

Closed
NicolasHug opened this issue Aug 22, 2023 · 1 comment
Closed

DOC - how do we import v2 namespaces and datapoints #7866

NicolasHug opened this issue Aug 22, 2023 · 1 comment

Comments

@NicolasHug
Copy link
Member

The way we write our docs largely influences what user/our code will look like.

Right now we mostly do

from torchvision.transforms import v2

v2.Resize()

There are different options like import torchvision.transforms.v2 as T

We also need to decide how to import the functionals (In the past we've been rather inconsistent and went for things like TF which is potentially confusing).

We also need to decide whether we import datapoints, datapoints as dp, or just import the objects directly from that namespace like from torchvision.datapoints import BoundingBoxes

This is more about user-facing docs / code than about our internal code, but ideally we would align that as well. Our refactored tests use transforms for the module and I find that annoyingly verbose for zero added clarity.

@NicolasHug
Copy link
Member Author

NicolasHug commented Sep 2, 2024

I don't think we'll come back to this, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant