Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration-test.yml #2043

Closed
wants to merge 4 commits into from
Closed

Update integration-test.yml #2043

wants to merge 4 commits into from

Conversation

joecummings
Copy link
Contributor

No description provided.

Nayef211
Nayef211 reviewed Feb 2, 2023
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the linter errors? Also the integration test failures look relevant

@rshraga
Copy link
Contributor

rshraga commented Feb 7, 2023

@joecummings I can commandeer this. You mentioned having some additional context?

@joecummings
Copy link
Contributor Author

yep feel free to commandeer. I'll chat you the extra context @rshraga

@joecummings
Copy link
Contributor Author

Closing in favor of #2051

@joecummings joecummings closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joecummings @rshraga @Nayef211 @facebook-github-bot